Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add goss testing for the docker image #4459

Merged
merged 9 commits into from
May 21, 2024

Conversation

jippi
Copy link
Contributor

@jippi jippi commented Apr 19, 2024

what

Adding automatic testing for the container image to avoid regressions like #4439 and #4458

why

Testing is good

tests

Running the tests in CI

references

@jippi jippi requested review from a team as code owners April 19, 2024 13:51
@jippi jippi requested review from jamengual, nitrocode and X-Guardian and removed request for a team April 19, 2024 13:51
@jippi jippi force-pushed the add-goss-image-testing branch from 4c07e71 to 8c13dd1 Compare April 19, 2024 13:57
@jippi jippi force-pushed the add-goss-image-testing branch from 8c13dd1 to 172e34c Compare April 19, 2024 14:47
@jippi
Copy link
Contributor Author

jippi commented Apr 25, 2024

This PR is up to date and ready for review/merge :)

@jamengual jamengual added the waiting-on-review Waiting for a review from a maintainer label Apr 30, 2024
@jippi
Copy link
Contributor Author

jippi commented May 7, 2024

Anything blocking this from going in? It would have detected a pretty significant regression in Atlantis, and a nice corner stone for further verification of the container images we build down the road :)

@jamengual
Copy link
Contributor

Anything blocking this from going in? It would have detected a pretty significant regression in Atlantis, and a nice corner stone for further verification of the container images we build down the road :)

time, is always time to review.

@jamengual jamengual added the docker Pull requests that update Docker code label May 7, 2024
chenrui333
chenrui333 previously approved these changes May 19, 2024
@chenrui333 chenrui333 requested a review from nitrocode May 19, 2024 21:00
@jippi
Copy link
Contributor Author

jippi commented May 19, 2024

@chenrui333 applied your suggested edits :)

Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chenrui333 chenrui333 merged commit 8c5bb21 into runatlantis:main May 21, 2024
26 checks passed
@jippi jippi deleted the add-goss-image-testing branch May 21, 2024 20:49
ragne pushed a commit to ragne/atlantis that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Pull requests that update Docker code github-actions waiting-on-review Waiting for a review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants